[PATCH] Change in core[libreoffice-3-6]: Resolves: fdo#45911 rhbz#846775 Clipboard must be disposed b...

[Caolán McNamara (via_Code_Review)]

Hi,

I have submitted a patch for review:

    https://gerrit.libreoffice.org/1612

To pull it, you can do:

    git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/12/1612/1

Resolves: fdo#45911 rhbz#846775 Clipboard must be disposed before Selection

(cherry picked from commit 7887a4e0adb0d60e6b013808dc27eccddd1c0324)

Change-Id: I968bc6da85cd444d504b08f85300a1fe251cdeee
---
M sd/source/ui/slidesorter/controller/SlideSorterController.cxx
M sd/source/ui/slidesorter/inc/controller/SlideSorterController.hxx
2 files changed, 4 insertions(+), 3 deletions(-)



diff --git a/sd/source/ui/slidesorter/controller/SlideSorterController.cxx b/sd/source/ui/slidesorter/controller/SlideSorterController.cxx
index 2932e20..7ab51b4 100644
--- a/sd/source/ui/slidesorter/controller/SlideSorterController.cxx
+++ b/sd/source/ui/slidesorter/controller/SlideSorterController.cxx
@@ -110,10 +110,10 @@
       mpPageSelector(),
       mpFocusManager(),
       mpSlotManager(),
-      mpClipboard(),
       mpScrollBarManager(),
       mpCurrentSlideManager(),
       mpSelectionManager(),
+      mpClipboard(),
       mpInsertionIndicatorHandler(new InsertionIndicatorHandler(rSlideSorter)),
       mpAnimator(new Animator(rSlideSorter)),
       mpVisibleAreaManager(new VisibleAreaManager(rSlideSorter)),
@@ -156,9 +156,9 @@
     mpPageSelector.reset(new PageSelector(mrSlideSorter));
     mpFocusManager.reset(new FocusManager(mrSlideSorter));
     mpSlotManager.reset(new SlotManager(mrSlideSorter));
-    mpClipboard.reset(new Clipboard(mrSlideSorter));
     mpScrollBarManager.reset(new ScrollBarManager(mrSlideSorter));
     mpSelectionManager.reset(new SelectionManager(mrSlideSorter));
+    mpClipboard.reset(new Clipboard(mrSlideSorter));
 
     mpScrollBarManager->LateInitialization();
 
@@ -202,6 +202,7 @@
 void SlideSorterController::Dispose (void)
 {
     mpInsertionIndicatorHandler->End(Animator::AM_Immediate);
+    mpClipboard.reset();
     mpSelectionManager.reset();
     mpAnimator->Dispose();
 }
diff --git a/sd/source/ui/slidesorter/inc/controller/SlideSorterController.hxx b/sd/source/ui/slidesorter/inc/controller/SlideSorterController.hxx
index e962623..c515480 100644
--- a/sd/source/ui/slidesorter/inc/controller/SlideSorterController.hxx
+++ b/sd/source/ui/slidesorter/inc/controller/SlideSorterController.hxx
@@ -245,10 +245,10 @@
     ::boost::scoped_ptr<PageSelector> mpPageSelector;
     ::boost::scoped_ptr<FocusManager> mpFocusManager;
     ::boost::shared_ptr<SlotManager> mpSlotManager;
-    ::boost::scoped_ptr<controller::Clipboard> mpClipboard;
     ::boost::scoped_ptr<ScrollBarManager> mpScrollBarManager;
     mutable ::boost::shared_ptr<CurrentSlideManager> mpCurrentSlideManager;
     ::boost::shared_ptr<SelectionManager> mpSelectionManager;
+    ::boost::scoped_ptr<controller::Clipboard> mpClipboard;
     ::boost::shared_ptr<InsertionIndicatorHandler> mpInsertionIndicatorHandler;
     ::boost::shared_ptr<Animator> mpAnimator;
     ::boost::scoped_ptr<VisibleAreaManager> mpVisibleAreaManager;

-- 
To view, visit https://gerrit.libreoffice.org/1612
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I968bc6da85cd444d504b08f85300a1fe251cdeee
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: libreoffice-3-6
Gerrit-Owner: Caolán McNamara <caolanm at redhat.com>