replacing OUString::valueOf(static_cast<sal_Int32>) ??

[Michael Meeks]

On Wed, 2013-01-09 at 18:26 +0100, Lubos Lunak wrote:
> > but you'll at least implicitly cast the same way on all platforms (since
> > the sal types don't map to arbitrary types, but to types of a particular
> > size).
> 
>  The explicit cast will also always be the same way on all platforms.

	Sure - but the explicit cast is not required :-) people can omit it,
compile perfectly cleanly on 64bit, commit - and then all the 32bit
systems break :-)

	Unless I'm missing something, there is no way beyond: "do manual work
regularly to fix it" to deal with that sort of fall-out - and that's the
primary reason why we might want to prefer valueOfInt32() and
deprecating valueOf() - even though it's longer.

	At least in my mind :-) but we're starting to bike-shed here... I
didn't see anyone volunteering to do the actual batch cleanup there ;-)

	Regards,

		Michael.

-- 
michael.meeks at suse.com  <><, Pseudo Engineer, itinerant idiot