[REVIEW-4-0] oxygen-gtk support version ...

Michael Meeks michael.meeks at suse.com
Thu Jan 10 09:41:50 PST 2013


Hi there,

On Wed, 2013-01-09 at 21:08 +0400, Ruslan Kabatsayev wrote:
> >>      gtk_init_check( &nParams, &pCmdLineAry );
> >> +    g_setenv("LibreOffice_Version","4.0.0.0",true);
...
> >> Of course, "4.0.0.0" should be replaced by some variable, name of
> >> which I currently don't know. But how do you like this idea? It seems
> >> the easiest and most efficient compared to any g_object_set_data()
> >> way.

	I cleaned up the version bits (as well as I could in a back-portable
way for 4.0 - really we should drive this all from one setting in
configure.in IMHO).

	I'd like to get the result into -4-0 if someone could review/ pick
these two:

http://cgit.freedesktop.org/libreoffice/core/commit/?id=364cce0a511d3e7a3bbc51e09895999fbdf0dbe1
http://cgit.freedesktop.org/libreoffice/core/commit/?id=0260f0b256c3675bb6d836c0a2babb7626577b7a

	And hopefully it'd be possible (any chance you could do that Tor?) to
file an easy-hack to kill remaining code-based 'SUPD' uses to use
LIBO_VERSION_ bits

	Thanks !

		Michael.

-- 
michael.meeks at suse.com  <><, Pseudo Engineer, itinerant idiot



More information about the LibreOffice mailing list