[PATCH] Change in core[libreoffice-4-0]: docx export: fix regression on table borders export

Pierre-Eric Pelloux-Prayer (via Code Review) gerrit at gerrit.libreoffice.org
Tue Jan 15 16:15:36 PST 2013


Hi,

I have submitted a patch for review:

    https://gerrit.libreoffice.org/1705

To pull it, you can do:

    git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/05/1705/1

docx export: fix regression on table borders export

The removed code was supposed to allow LO to write cell borders only
if they were different from default cell border.
Bug #59275 show that this is incorrect.

Change-Id: If31914c412480fdadb775ca6675999ecde3e6bba
---
M sw/source/filter/ww8/docxattributeoutput.cxx
1 file changed, 0 insertions(+), 9 deletions(-)



diff --git a/sw/source/filter/ww8/docxattributeoutput.cxx b/sw/source/filter/ww8/docxattributeoutput.cxx
index 475645b..fb0b396 100644
--- a/sw/source/filter/ww8/docxattributeoutput.cxx
+++ b/sw/source/filter/ww8/docxattributeoutput.cxx
@@ -1466,15 +1466,6 @@
     for( int i = 0; i < 4; ++i, ++pBrd )
     {
         const SvxBorderLine* pLn = rBox.GetLine( *pBrd );
-        if ( pDefaultBorders && pLn )
-        {
-            const SvxBorderLine* pRefLn = pDefaultBorders->GetLine( *pBrd );
-
-            // If border is equal to default border: do not output
-            if ( pRefLn && *pLn == *pRefLn) {
-                continue;
-            }
-        }
 
         if (!tagWritten && bWriteTag) {
             pSerializer->startElementNS( XML_w, tag, FSEND );

-- 
To view, visit https://gerrit.libreoffice.org/1705
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: If31914c412480fdadb775ca6675999ecde3e6bba
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: libreoffice-4-0
Gerrit-Owner: Pierre-Eric Pelloux-Prayer <pierre-eric at lanedo.com>



More information about the LibreOffice mailing list