[SOLVED] Re: Cppcheck : unused "pUnicodes" variable in pdfwriter_impl.cxx

Julien Nabet serval2412 at yahoo.fr
Sat Jan 19 01:13:44 PST 2013


On 18/01/2013 12:08, Caolán McNamara wrote:
> On Thu, 2013-01-17 at 13:43 -0800, julien2412 wrote:
>> Hello,
>>
>> Cppcheck reported this:
>> vcl/source/gdi/pdfwriter_impl.cxx
>> 3203	unreadVariable	style	Variable 'pUnicodes' is assigned a value that is
>> never used
>> Can we just remove it or something lacking?
> Go ahead and remove the pUnicodes, its been unused since the initial
> commit in 2009, and there isn't anything local to that code that seems
> to have an intent to consume it.
Thank you Caolán, I pushed a fix on master (see 
http://cgit.freedesktop.org/libreoffice/core/commit/?id=8a894b4af476641062bf340a2fb802558bf1cbe3)

Julien


More information about the LibreOffice mailing list