About parenthesis problem in testintrosp.cxx

Stephan Bergmann sbergman at redhat.com
Mon Jan 21 02:59:39 PST 2013


On 01/19/2013 06:27 PM, julien2412 wrote:
> Here's a problem in stoc/test/testintrosp.cxx, line 182
> aRetStr = aRetStr + OUString( OUString(" (Typ: ") ) + xIdlClass->getName() +
> OUString(""));
>
> By taking a look at git history, I found that it was:
> aRetStr = aRetStr + OUString( OUString(RTL_CONSTASCII_USTRINGPARAM(" (Typ:
> ")) ) + xIdlClass->getName() + OUString(RTL_CONSTASCII_USTRINGPARAM(")"));
> before 02/06/2012
>
> If testintrosp.cxx is still used, an idea how to make this line more clear
> (and perhaps removing the double use of OUString)?

What I wrote in my other reply about bitrotten */workben/ code also 
applies for apparently bitrotten */test/ code (though with test code 
there /is/ useful code that is routinely built, spread across */qa/ and 
*/test/ directories, so be careful).

Stephan



More information about the LibreOffice mailing list