[PATCH] Change in core[libreoffice-4-0]: resolved fdo#59583 prevent inappropriate column/row label de...

[Eike Rathke (via Code Review)]

Hi,

I have submitted a patch for review:

    https://gerrit.libreoffice.org/1796

To pull it, you can do:

    git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/96/1796/1

resolved fdo#59583 prevent inappropriate column/row label detection

If followed by '(' (with or without space inbetween) an identifier can
not be a column/row label. Prevent arbitrary content detection in case a
macro function of the same name is meant (fdo#59583) or if it wouldn't
resolve to a known function name at all, that earlier resulted in #REF!
instead of #NAME? in the case of unknown function but label found.

(cherry picked from commit aa2b8bde171bf9562536dc14b2cf81d81e31b438)

Change-Id: Ib86687bdecfcf5897f4700086fc9969cc3fab0f0
---
M sc/source/core/tool/compiler.cxx
1 file changed, 3 insertions(+), 1 deletion(-)



diff --git a/sc/source/core/tool/compiler.cxx b/sc/source/core/tool/compiler.cxx
index b6183ba..74c2be9 100644
--- a/sc/source/core/tool/compiler.cxx
+++ b/sc/source/core/tool/compiler.cxx
@@ -3687,7 +3687,9 @@
             return true;
         if (IsDBRange( aUpper ))
             return true;
-        if (IsColRowName( aUpper ))
+        // If followed by '(' (with or without space inbetween) it can not be a
+        // column/row label. Prevent arbitrary content detection.
+        if (!bMayBeFuncName && IsColRowName( aUpper ))
             return true;
         if (bMayBeFuncName && IsMacro( aUpper ))
             return true;

-- 
To view, visit https://gerrit.libreoffice.org/1796
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib86687bdecfcf5897f4700086fc9969cc3fab0f0
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: libreoffice-4-0
Gerrit-Owner: Eike Rathke <erack at redhat.com>