[PATCH] Resolves fdo#59117 fixes missing border of last column

Karthikeyan Krishnamurthi (via Code Review) gerrit at gerrit.libreoffice.org
Mon Jan 21 23:09:55 PST 2013


Hi,

I have submitted a patch for review:

    https://gerrit.libreoffice.org/1805

To pull it, you can do:

    git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/05/1805/1

Resolves fdo#59117 fixes missing border of last column

The table's layout should not change to RTL with the selection
of paragaraph left, right toolbar icons.  It should change the
 layout only when the document is in RTL.

Change-Id: I3c9a95169ea1581d44c176ec260a9cbf818913ab
---
M svx/source/table/viewcontactoftableobj.cxx
1 file changed, 9 insertions(+), 7 deletions(-)



diff --git a/svx/source/table/viewcontactoftableobj.cxx b/svx/source/table/viewcontactoftableobj.cxx
index a74dc60..42501f1 100644
--- a/svx/source/table/viewcontactoftableobj.cxx
+++ b/svx/source/table/viewcontactoftableobj.cxx
@@ -17,7 +17,7 @@
  *   the License at http://www.apache.org/licenses/LICENSE-2.0 .
  */
 
-
+#include "vcl/svapp.hxx"
 #include "viewcontactoftableobj.hxx"
 #include <svx/svdotable.hxx>
 #include <com/sun/star/table/XTable.hpp>
@@ -357,7 +357,7 @@
                 }
             }
 
-            if(!getRightLine().isEmpty() && getRightIsOutside())
+            if(!getRightLine().isEmpty())
             {
                 // create right line from top to bottom
                 const basegfx::B2DPoint aStart(getTransform() * basegfx::B2DPoint(1.0, 0.0));
@@ -491,12 +491,13 @@
                             // mirror all left lines
                             bMirror = (bIsRTL ? 0 != nX : nX != nColCount);
                         }
+                        if(bMirror)
+                        {
+                            aLine.SetMirrorWidths( );
+                        }
+
                     }
 
-                    if(bMirror)
-                    {
-                        aLine.SetMirrorWidths( );
-                    }
 
                     return;
                 }
@@ -523,7 +524,8 @@
                 if(nAllCount)
                 {
                     const sdr::table::TableLayouter& rTableLayouter = rTableObj.getTableLayouter();
-                    const bool bIsRTL(com::sun::star::text::WritingMode_RL_TB == rTableObj.GetWritingMode());
+                    const bool bIsRTL(Application::GetSettings().GetLayoutRTL());
+
                     sdr::table::CellPos aCellPos;
                     sdr::table::CellRef xCurrentCell;
                     basegfx::B2IRectangle aCellArea;

-- 
To view, visit https://gerrit.libreoffice.org/1805
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I3c9a95169ea1581d44c176ec260a9cbf818913ab
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Karthikeyan Krishnamurthi <karthikeyan at kacst.edu.sa>



More information about the LibreOffice mailing list