Cppcheck: false positive in pptx-text.cxx ?

[Eike Rathke]

Hi Markus,

On Sunday, 2013-01-20 19:55:17 +0100, Markus Mohrhard wrote:

> >    1233 TextObj::TextObj( const TextObj& rTextObj )
> >    1234 {
> >    1235     mpImplTextObj =
> > const_cast<TextObj&>(rTextObj).mpImplTextObj;
> >    1236     mpImplTextObj->mnRefCount++;
> >    1237 }
> 
> Someone implemented here manualy ref counting. If you want to remove
> the warning you can replace the raw pointer + the ref counting
> variable with a  boost::shared_ptr.

While boost::shared_ptr is of course cleaner code, for mass objects it
may add a runtime performance penalty if they are passed around a lot.
For example I wouldn't change formula tokens to shared_ptr ...

  Eike

-- 
LibreOffice Calc developer. Number formatter stricken i18n transpositionizer.
New GnuPG key 0x65632D3A : 2265 D7F3 A7B0 95CC 3918  630B 6A6C D5B7 6563 2D3A
Old GnuPG key 0x293C05FD : 997A 4C60 CE41 0149 0DB3  9E96 2F1A D073 293C 05FD
Support the FSFE, care about Free Software! https://fsfe.org/support/?erack
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20130122/4b8694aa/attachment.pgp>