[PATCH] Resolves the bug fdo#59117 missing borders of last column

[Karthikeyan Krishnamurthi (via Code Review)]

Hi,

I have submitted a patch for review:

    https://gerrit.libreoffice.org/1834

To pull it, you can do:

    git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/34/1834/1

Resolves the bug fdo#59117 missing borders of last column

  When writingmode is set to RTL, the table is start drawn from Last column
to first column.  There is no problem with left&right lines, Because these
are not depends on the LTR or RTL writingmode.  But the bottom & top line
depends on writing mode.  As these two lines are drawn from previous cell to
next cell(left to right) the nX value should be nX-1 in RTL writingmode.

Change-Id: I3e21c7dd469ed5ba29e66f79da471b662632182e
---
M svx/source/table/viewcontactoftableobj.cxx
1 file changed, 5 insertions(+), 3 deletions(-)



diff --git a/svx/source/table/viewcontactoftableobj.cxx b/svx/source/table/viewcontactoftableobj.cxx
index a74dc60..1f9f7d2 100644
--- a/svx/source/table/viewcontactoftableobj.cxx
+++ b/svx/source/table/viewcontactoftableobj.cxx
@@ -357,7 +357,7 @@
                 }
             }
 
-            if(!getRightLine().isEmpty() && getRightIsOutside())
+            if(!getRightLine().isEmpty())
             {
                 // create right line from top to bottom
                 const basegfx::B2DPoint aStart(getTransform() * basegfx::B2DPoint(1.0, 0.0));
@@ -622,9 +622,11 @@
 
                                     // get basic lines
                                     impGetLine(aLeftLine, rTableLayouter, nX, nY, false, nColCount, nRowCount, bIsRTL);
-                                    impGetLine(aBottomLine, rTableLayouter, nX, nYBottom, true, nColCount, nRowCount, bIsRTL);
+                                    //To resolve the bug fdo#59117
+                                    //In RTL table as BottomLine & TopLine are drawn from Left Side to Right, nX should be nX-1
+                                    impGetLine(aBottomLine, rTableLayouter, bIsRTL?nX-1:nX, nYBottom, true, nColCount, nRowCount, bIsRTL);
                                     impGetLine(aRightLine, rTableLayouter, nXRight, nY, false, nColCount, nRowCount, bIsRTL);
-                                    impGetLine(aTopLine, rTableLayouter, nX, nY, true, nColCount, nRowCount, bIsRTL);
+                                    impGetLine(aTopLine, rTableLayouter, bIsRTL?nX-1:nX, nY, true, nColCount, nRowCount, bIsRTL);
 
                                     // get the neighbor cells' borders
                                     impGetLine(aLeftFromTLine, rTableLayouter, nX, nY - 1, false, nColCount, nRowCount, bIsRTL);

-- 
To view, visit https://gerrit.libreoffice.org/1834
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I3e21c7dd469ed5ba29e66f79da471b662632182e
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Karthikeyan Krishnamurthi <karthikeyan at kacst.edu.sa>