Change in core[master]: configure: accept building without themes

Riccardo Magliocchetti (via Code Review) gerrit at gerrit.libreoffice.org
Sat Jan 26 08:06:55 PST 2013


Hi,

I have submitted a patch for review:

    https://gerrit.libreoffice.org/1879

To pull it, you can do:

    git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/79/1879/1

configure: accept building without themes

If --with-theme=no is specified disallow any check for valid themes
which would otherwise give an error.

Change-Id: I45d2872145f3bd15e17beac4f69f8b4b1855d9a3
---
M configure.ac
1 file changed, 10 insertions(+), 8 deletions(-)



diff --git a/configure.ac b/configure.ac
index dc13c15..7a29b48 100644
--- a/configure.ac
+++ b/configure.ac
@@ -10824,14 +10824,16 @@
 fi
 
 WITH_THEMES=""
-for theme in $with_theme; do
-    case $theme in
-        crystal|default|galaxy|hicontrast|human|industrial|oxygen|tango|tango_testing) : ;;
-        *) AC_MSG_ERROR([Unknown value for --with-theme: $theme]) ;;
-    esac
-    WITH_THEMES="$WITH_THEMES $theme"
-    SCPDEFS="$SCPDEFS -DTHEME_`echo $theme|tr '[[:lower:]]' '[[:upper:]]'`"
-done
+if test "x$with_theme" != "xno"; then
+    for theme in $with_theme; do
+        case $theme in
+            crystal|default|galaxy|hicontrast|human|industrial|oxygen|tango|tango_testing) : ;;
+            *) AC_MSG_ERROR([Unknown value for --with-theme: $theme]) ;;
+        esac
+        WITH_THEMES="$WITH_THEMES $theme"
+        SCPDEFS="$SCPDEFS -DTHEME_`echo $theme|tr '[[:lower:]]' '[[:upper:]]'`"
+    done
+fi
 AC_MSG_RESULT([$WITH_THEMES])
 AC_SUBST([WITH_THEMES])
 

-- 
To view, visit https://gerrit.libreoffice.org/1879
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I45d2872145f3bd15e17beac4f69f8b4b1855d9a3
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Riccardo Magliocchetti <riccardo.magliocchetti at gmail.com>


More information about the LibreOffice mailing list