Change in core[libreoffice-4-0-0]: Resolving crash in wizards fdo#59931 by NULL checking

Stephan Bergmann (via Code Review) gerrit at gerrit.libreoffice.org
Mon Jan 28 23:57:51 PST 2013


Hi,

I have submitted a patch for review:

    https://gerrit.libreoffice.org/1913

To pull it, you can do:

    git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/13/1913/1

Resolving crash in wizards fdo#59931 by NULL checking

Change-Id: Iccc3f3b2913f21a3831ce55c706aa4dd1da53ad6
Reviewed-on: https://gerrit.libreoffice.org/1909
Reviewed-by: Stephan Bergmann <sbergman at redhat.com>
Tested-by: Stephan Bergmann <sbergman at redhat.com>
(cherry picked from commit 78fde59e65bf1fbf8290e60b8cbe4b34e3489b93)
---
M svtools/source/control/roadmap.cxx
1 file changed, 4 insertions(+), 1 deletion(-)



diff --git a/svtools/source/control/roadmap.cxx b/svtools/source/control/roadmap.cxx
index a0239cf..6a23688 100644
--- a/svtools/source/control/roadmap.cxx
+++ b/svtools/source/control/roadmap.cxx
@@ -700,7 +700,10 @@
             SetFont( aFont );
             RoadmapTypes::ItemId curItemID = GetCurrentRoadmapItemID();
             RoadmapItem* pLabelItem = GetByID( curItemID );
-            pLabelItem->ToggleBackgroundColor(rStyleSettings.GetHighlightColor());
+            if (pLabelItem != NULL)
+            {
+                pLabelItem->ToggleBackgroundColor(rStyleSettings.GetHighlightColor());
+            }
             Invalidate();
         }
     }

-- 
To view, visit https://gerrit.libreoffice.org/1913
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iccc3f3b2913f21a3831ce55c706aa4dd1da53ad6
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: libreoffice-4-0-0
Gerrit-Owner: Stephan Bergmann <sbergman at redhat.com>
Gerrit-Reviewer: Arnaud Versini <arnaud.versini at gmail.com>


More information about the LibreOffice mailing list