Moving Code From /core/sw... to /core/vcl

[Joel Madero]

Hi All,

This is the most challenging hack I've done and I'm looking for some
pointers.

I am trying to make it so that pushing "Ok" on print dialog saves the
component options. This is currently done in Writer (although imperfectly)
within sw --

http://opengrok.libreoffice.org/xref/core/sw/source/ui/uno/unotxdoc.cxx#2439

Imperfectly in that the code is called too often:

a) when you open print dialog
b) when you push ok
c) when you change any option

So the option gets saved on pushing the radio button vs. when you push ok
-- leading it to be that pushing Cancel on print dialog doesn't discard
changes.

I am relatively sure that this has to be moved to vcl level in order for
the above code to work correctly (only gets called when you push ok) and to
make it so that we can set it up where every component works the same. I'm
thinking here:

http://opengrok.libreoffice.org/xref/core/vcl/source/window/printdlg.cxx#469

looks relatively nice and cohesive.

I'm looking to find out:

a) am I on the right track (ie. is moving the code really the best way to
tackle this)
b) if so, pointers would be helpful, a lot of undeclared stuff happens when
I make the change so I'm assuming I'm going to either have to include a
bunch of hxx files from sw (not good?) or create new hxx files somewhere
else that does similar things as the ones in hxx although possibly more
generalized.


Best Regards (apologies if I wasn't clear)

Joel

-- 
*Joel Madero*
LibO QA Volunteer
jmadero.dev at gmail.com
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20130129/1c601806/attachment.html>