[Libreoffice-commits] replaceAll

Michael Meeks michael.meeks at suse.com
Wed Jan 30 16:58:55 PST 2013


On Wed, 2013-01-30 at 16:26 +0100, Stephan Bergmann wrote:
> >      fix for the awkward OUString::replaceAll() behaviour
>
> Seeing this, that's the reason I've always been unhappy with such a 
> replaceAll function:  While it may appear "obviously useful," it easily 
> leads to broken code (like if rInfo1 is "wanna bet $2 this doesn't 
> work?", say, in the above snippet).

	We could deprecate it. Do we have a nice macro wrapped around some
magic gcc: "really warn if return value unused" attribute - I assume
there is one of those - that might help make it more sane ?

	ATB,

		Michael.

-- 
michael.meeks at suse.com  <><, Pseudo Engineer, itinerant idiot



More information about the LibreOffice mailing list