[Libreoffice-commits] replaceAll

Noel Grandin noel at peralex.com
Thu Jan 31 00:45:08 PST 2013


On 2013-01-31 10:32, Stephan Bergmann wrote:
>
> You missed my point, which was not the gotcha of ignoring the return 
> value (which is already addressed with SAL_WARN_UNUSED_RESULT anyway), 
> but the gotcha that a sequence of replaceAll calls to replace multiple 
> placeholders with corresponding replacement values is broken in 
> general (unless you can ensure that each invocation in the sequence 
> does not introduce new instances of "subsequent" placeholders into the 
> operated-upon string).

Then perhaps we need some kind of
     OUString replaceArgs(const OUString& source,
                                           const OUString&[] args,
                                           const OUString&[] values)
helper method that DTRT?


Disclaimer: http://www.peralex.com/disclaimer.html




More information about the LibreOffice mailing list