Change in core[libreoffice-4-0]: we need to use SCROW for row numbers, fdo#59894

[Markus Mohrhard (via Code Review)]

Hi,

I have submitted a patch for review:

    https://gerrit.libreoffice.org/1945

To pull it, you can do:

    git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/45/1945/1

we need to use SCROW for row numbers, fdo#59894

This caused an overflow and resulted in adding endless number of values
until a bad_alloc was thrown.

Change-Id: I954acd801eb18e2c2fe6a449048856cb95d0d8b0
---
M sc/source/core/data/colorscale.cxx
1 file changed, 1 insertion(+), 1 deletion(-)



diff --git a/sc/source/core/data/colorscale.cxx b/sc/source/core/data/colorscale.cxx
index 55b8b43..3fe033a 100644
--- a/sc/source/core/data/colorscale.cxx
+++ b/sc/source/core/data/colorscale.cxx
@@ -293,7 +293,7 @@
             SCTAB nTab = pRange->aStart.Tab();
             for(SCCOL nCol = pRange->aStart.Col(); nCol <= pRange->aEnd.Col(); ++nCol)
             {
-                for(SCCOL nRow = pRange->aStart.Row(); nRow <= pRange->aEnd.Row(); ++nRow)
+                for(SCROW nRow = pRange->aStart.Row(); nRow <= pRange->aEnd.Row(); ++nRow)
                 {
                     ScAddress aAddr(nCol, nRow, nTab);
                     CellType eType = mpDoc->GetCellType(aAddr);

-- 
To view, visit https://gerrit.libreoffice.org/1945
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I954acd801eb18e2c2fe6a449048856cb95d0d8b0
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: libreoffice-4-0
Gerrit-Owner: Markus Mohrhard <markus.mohrhard at googlemail.com>