OConnection.cxx patch

Lionel Elie Mamane lionel at mamane.lu
Fri Jul 5 00:20:34 PDT 2013


On Thu, Jul 04, 2013 at 08:44:52AM +0200, Gabriele Bulfon wrote:

> I had to patch this file to build without errors:
> --- libreoffice-4.1.0.1/connectivity/source/drivers/odbcbase/OConnection.cxx    Thu Jul  4 08:33:42 2013
> +++ libreoffice-4.1.0.1/connectivity/source/drivers/odbcbase/OConnection.cxx    Thu Jul  4 08:34:55 2013
> @@ -417,7 +417,7 @@ checkDisposed(OConnection_BASE::rBHelper.bDisposed);
> -    sal_Int32 nValueLen;
> +    SQLINTEGER nValueLen;

This change makes sense. Thank you for your contribution. However,
before I can use it, could you please confirm that you allow us to use
it under the MPLv2/LGPLv3+ dual license? I don't find your name on the
list of people that have already agreed to that
https://wiki.documentfoundation.org/Development/Developers

It is customary to do a general statement that covers all your past,
present and future contributions; see
https://wiki.documentfoundation.org/Development/Developers#Example_Statement
and
https://wiki.documentfoundation.org/Development/Developers#Where_do_I_send_the_Statement.3F


Also, please send your patches as attachments, to avoid your mail user
agent (email program) to change spacing, do word wrapping, etc, which
makes the patch harder to read, and makes the "patch" program fail to
use it automatically.

-- 
Lionel


More information about the LibreOffice mailing list