[PATCH] gbuild: update included dep-targets as side effect of target...
Michael Stahl (via Code Review)
gerrit at gerrit.libreoffice.org
Tue Jul 16 06:13:52 PDT 2013
Hello LibreOffice gerrit bot,
I'd like you to reexamine a change. Please visit
to look at the new patch set (#2).
Change subject: gbuild: update included dep-targets as side effect of targets
gbuild: update included dep-targets as side effect of targets
Make builds in 2 phases: first it ensures that all targets that are
included by the makefiles (i.e. the .d files) are up to date, then
it restarts and builds everything else.
It would be possible to update the .d files in the same build by simply
having dependencies from the dep-targets to the corresponding real targets,
but that has undesirable effects (8b5a984d45005d3df1c89eae897d6e04612625d8).
For a successful build, the .d files can actually be updated as a side
effect of other rules in such a way that they will be up-to-date on the
next make invocation, thus the restart can be avoided.
This optimization will not always work in case of build failures.
3 files changed, 39 insertions(+), 15 deletions(-)
git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/04/4904/2
To view, visit https://gerrit.libreoffice.org/4904
To unsubscribe, visit https://gerrit.libreoffice.org/settings
Gerrit-Owner: Michael Stahl <mstahl at redhat.com>
Gerrit-Reviewer: LibreOffice gerrit bot <gerrit at libreoffice.org>
More information about the LibreOffice