Cppcheck: duplicateBranch in ParaPropertyPanel.cxx (svx module)

[julien2412]

Hello,

Cppcheck reported this:
<error file="svx/source/sidebar/paragraph/ParaPropertyPanel.cxx" line="309"
id="duplicateBranch" severity="style" msg="Found duplicate branches for 'if'
and 'else'."/>
<error file="svx/source/sidebar/paragraph/ParaPropertyPanel.cxx" line="328"
id="duplicateBranch" severity="style" msg="Found duplicate branches for 'if'
and 'else'."/>
Indeed, see
http://opengrok.libreoffice.org/xref/core/svx/source/sidebar/paragraph/ParaPropertyPanel.cxx#309
    309     if( Application::GetSettings().GetLayoutRTL())
    310     {
    311         mpTbxIndent_IncDec->SetItemImage(nIdIncrement,
maIncIndentControl.GetIcon());
    312         mpTbxIndent_IncDec->SetItemImage(nIdDecrement,
maDecIndentControl.GetIcon());
    313     }
    314     else
    315     {
    316         mpTbxIndent_IncDec->SetItemImage(nIdIncrement,
maIncIndentControl.GetIcon());
    317         mpTbxIndent_IncDec->SetItemImage(nIdDecrement,
maDecIndentControl.GetIcon());
    318     }

    328     if( Application::GetSettings().GetLayoutRTL())
    329     {
    330         mpTbxProDemote->SetItemImage(nIdPromote,
maOutLineLeftControl.GetIcon());
    331         mpTbxProDemote->SetItemImage(nIdDemote,
maOutLineRightControl.GetIcon());
    332     }
    333     else
    334     {
    335         mpTbxProDemote->SetItemImage(nIdPromote,
maOutLineLeftControl.GetIcon());
    336         mpTbxProDemote->SetItemImage(nIdDemote,
maOutLineRightControl.GetIcon());
    337     }

Any idea how it should be?

Julien



--
View this message in context: http://nabble.documentfoundation.org/Cppcheck-duplicateBranch-in-ParaPropertyPanel-cxx-svx-module-tp4067942.html
Sent from the Dev mailing list archive at Nabble.com.