Clean-up of split filter implementations needed
sbergman at redhat.com
Mon Jun 3 06:48:02 PDT 2013
"No need for two Excel filter services" and
"Revert 'fdo#46808, Convert oox::PowerPointExport service to new style'"
I had noted two service implementations that were each split in two for
no apparent good reason, and those hacks were starting to grow.
In both cases, it was not immediately obvious to me how to fold the
import and the export implementation into a single C++ class, though.
(In the first case, I was able to remove the additional export service
completely by forwarding to it from the import service directly in C++.
In the second case, that was not trivially possible, as the export
service is implemented in sd and the import service in oox, and the
latter cannot include from the former.)
It would be great if anybody with deeper insight into
oox::core::XmlFilterBase etc. could clean this up further.
More information about the LibreOffice