[PATCH] Fix memory leak in SalGtkPicker::uritounicode.

Mark Wielaard (via Code Review) gerrit at gerrit.libreoffice.org
Tue Jun 4 14:07:07 PDT 2013


I have submitted a patch for review:


To pull it, you can do:

    git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/56/4156/1

Fix memory leak in SalGtkPicker::uritounicode.

The gchars array returned by g_filename_from_uri will be copied into
the OUString sEncoded and should be freed.

Change-Id: Ib610cce5848607826632c0f5e32020708dac7645
M vcl/unx/gtk/fpicker/SalGtkPicker.cxx
1 file changed, 1 insertion(+), 0 deletions(-)

diff --git a/vcl/unx/gtk/fpicker/SalGtkPicker.cxx b/vcl/unx/gtk/fpicker/SalGtkPicker.cxx
index d14c00b..ed976d7 100644
--- a/vcl/unx/gtk/fpicker/SalGtkPicker.cxx
+++ b/vcl/unx/gtk/fpicker/SalGtkPicker.cxx
@@ -60,6 +60,7 @@
             OUString sEncoded(pEncodedFileName, strlen(pEncodedFileName),
+            g_free (pEncodedFileName);
             INetURLObject aCurrentURL(sEncoded, INetURLObject::FSYS_UNX);
             sURL = aCurrentURL.getExternalURL();

To view, visit https://gerrit.libreoffice.org/4156
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib610cce5848607826632c0f5e32020708dac7645
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Mark Wielaard <mark at klomp.org>

More information about the LibreOffice mailing list