[PATCH] Fix memory leak in Exif::processExif. Delete aExifData when ...

[Mark Wielaard (via Code Review)]

Hi,

I have submitted a patch for review:

    https://gerrit.libreoffice.org/4171

To pull it, you can do:

    git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/71/4171/1

Fix memory leak in Exif::processExif. Delete aExifData when done.

Change-Id: I1e63727fb8d587401c72775a14e7e3572b04fff5
---
M vcl/source/filter/jpeg/Exif.cxx
1 file changed, 2 insertions(+), 0 deletions(-)



diff --git a/vcl/source/filter/jpeg/Exif.cxx b/vcl/source/filter/jpeg/Exif.cxx
index 167cf54..f44b54f 100644
--- a/vcl/source/filter/jpeg/Exif.cxx
+++ b/vcl/source/filter/jpeg/Exif.cxx
@@ -213,6 +213,7 @@
 
     if( 0x4949 != aTiffHeader->byteOrder || 0x002A != aTiffHeader->tagAlign )
     {
+        delete[] aExifData;
         return false;
     }
 
@@ -231,6 +232,7 @@
         rStream.Write(aExifData, aLength);
     }
 
+    delete[] aExifData;
     return true;
 }
 

-- 
To view, visit https://gerrit.libreoffice.org/4171
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I1e63727fb8d587401c72775a14e7e3572b04fff5
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Mark Wielaard <mark at klomp.org>