[PATCH] Fix memory leak in SelectionManager::getXdndVersion.

Mark Wielaard (via Code Review) gerrit at gerrit.libreoffice.org
Fri Jun 7 00:25:14 PDT 2013


Hi,

I have submitted a patch for review:

    https://gerrit.libreoffice.org/4186

To pull it, you can do:

    git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/86/4186/1

Fix memory leak in SelectionManager::getXdndVersion.

Release XListProperties atom properties of window after inspection.

Change-Id: I89d86509babd7a9d8ec65dbabe0a062bf69fc493
---
M vcl/unx/generic/dtrans/X11_selection.cxx
1 file changed, 3 insertions(+), 0 deletions(-)



diff --git a/vcl/unx/generic/dtrans/X11_selection.cxx b/vcl/unx/generic/dtrans/X11_selection.cxx
index 9cd2c0b..db613f3 100644
--- a/vcl/unx/generic/dtrans/X11_selection.cxx
+++ b/vcl/unx/generic/dtrans/X11_selection.cxx
@@ -3017,6 +3017,9 @@
             break;
         }
     }
+    if ( pProperties )
+        XFree (pProperties);
+
     XLIB_Window aAwareWindow = rProxy != None ? rProxy : aWindow;
 
     XGetWindowProperty( m_pDisplay, aAwareWindow, m_nXdndAware, 0, 1, False, XA_ATOM,

-- 
To view, visit https://gerrit.libreoffice.org/4186
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I89d86509babd7a9d8ec65dbabe0a062bf69fc493
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Mark Wielaard <mark at klomp.org>



More information about the LibreOffice mailing list