[PATCH] fdo#64626 clarify use of border line settings on toolbar

Winfried Donkers (via Code Review) gerrit at gerrit.libreoffice.org
Mon Jun 10 03:47:46 PDT 2013


I have submitted a patch for review:


To pull it, you can do:

    git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/20/4220/1

fdo#64626 clarify use of border line settings on toolbar

Using the toolbar button to set border lines in calc, lines are added,
but not removed. I thought this to be a bug, but it isn't. Using the
toolbar button is for addition, and using the same button with the SHIFT
key is for addition+deletion.

Unfortunately, this is not mentioned in help files or hints.
This patch remedies this by giving a better hint when using the toolbar

Change-Id: I0cf5cc9bffbec363cde3c7493f024cdfa72c54f4
M officecfg/registry/data/org/openoffice/Office/UI/GenericCommands.xcu
1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/officecfg/registry/data/org/openoffice/Office/UI/GenericCommands.xcu b/officecfg/registry/data/org/openoffice/Office/UI/GenericCommands.xcu
index dbdc93a..9771c68 100644
--- a/officecfg/registry/data/org/openoffice/Office/UI/GenericCommands.xcu
+++ b/officecfg/registry/data/org/openoffice/Office/UI/GenericCommands.xcu
@@ -1505,9 +1505,6 @@
         <prop oor:name="Label" oor:type="xs:string">
           <value xml:lang="en-US">What's ~This?</value>
-        <prop oor:name="Properties" oor:type="xs:int">
-          <value>1</value>
-        </prop>
       <node oor:name=".uno:ActiveHelp" oor:op="replace">
         <prop oor:name="Label" oor:type="xs:string">
@@ -2772,7 +2769,7 @@
       <node oor:name=".uno:SetBorderStyle" oor:op="replace">
         <prop oor:name="Label" oor:type="xs:string">
-          <value xml:lang="en-US">Borders</value>
+          <value xml:lang="en-US">Borders, add lines; SHIFT to add and remove</value>
         <prop oor:name="Properties" oor:type="xs:int">

To view, visit https://gerrit.libreoffice.org/4220
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I0cf5cc9bffbec363cde3c7493f024cdfa72c54f4
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Winfried Donkers <osc at dci-electronics.nl>

More information about the LibreOffice mailing list