[PATCH] dev-tools patch for gerrit script (was Re: gerrit daily )

Mat M matm at gmx.fr
Mon Jun 10 16:58:10 PDT 2013

Hello all

Le Thu, 06 Jun 2013 19:34:03 +0200, Bjoern Michaelsen  
<bjoern.michaelsen at canonical.com> a écrit:

> On Thu, Jun 06, 2013 at 04:48:52PM +0100, Michael Meeks wrote:
>> 	+ get the gerrit / mail digest bits setup (Bjoern)
>> 		[ in progress, scripts in dev-tools ]
> The script is now in a usable state IMHO, but of cause can always be  
> improved
> (like e.g. using Pythons mail-foo to construct the body, which might  
> make sure
> getting the encodings right for every client etc.).
> Below is the example mail this would send for "right now".
> Best,
> Bjoern
> Example output:
> From: gerrit at libreoffice.org
> To: libreoffice at lists.freedesktop.org
> Date: 2013-06-06 19:32:00.740745
> Subject: LibreOffice Gerrit news 2013-06-06
> Reply-To: libreoffice at lists.freedesktop.org
> X-Mailer: LibreOfficeGerritDigestMailer 1.0
> Moin!
> open changes on master for project core changed in the last 25 hours:
> https://gerrit.libreoffice.org/4176 "Sidebar conversion to .ui for  
> sidebar-number-format"                       prashant3.yishu at gmail.com
> https://gerrit.libreoffice.org/4169 fdo#63866 Hid useless  
> checkboxes                                            jsnhulme at gmail.com
> https://gerrit.libreoffice.org/4165 fdo#46808, Convert xml::crypto  
> services to new style                        noelgrandin at gmail.com
> merged changes on master for project core changed in the last 25 hours:
> https://gerrit.libreoffice.org/4174 Prevent out-of-range values coming  
> from ListBox GetSelectEntryPos.          javier.fgb at gmail.com
> https://gerrit.libreoffice.org/4170 Remove RTL_CONSTASCII_(U)STRINGPARAM  
> (sd)                                   ChrRossmanith at web.de
> https://gerrit.libreoffice.org/4151 fdo#41226 Add error handling of  
> recursed GetCaseCorrectPathNameEx()         saturday6c at gmail.com
> https://gerrit.libreoffice.org/4153 fdo#60924 autoinstall - gbuild/scp2:  
> add base module                        marcos.souza.org at gmail.com
> https://gerrit.libreoffice.org/4171 Fix memory leak in  
> Exif::processExif. Delete aExifData when done.           mark at klomp.org
> https://gerrit.libreoffice.org/4167 fdo#64350: fix for DOCX export of  
> border space                              rattles2013 at gmail.com
> abandoned changes on master for project core changed in the last 25  
> hours:
> None
> Open changes needing tweaks, but being untouched for more than a week:
> https://gerrit.libreoffice.org/3663 replaced compareTo with  
> ==                                                  p at nevitus.com
> Best,
> Your friendly LibreOffice Gerrit Digest Mailer

my patch is this:
Sanitize the age query parameters with --
Improve layout of mail like:

* Open changes on master for project core changed in the last 25 hours:

Rework code after OUString'ification
   in https://gerrit.libreoffice.org/4214 from Matteo Casalin
Simplify SwPaM::GetTxt
   in https://gerrit.libreoffice.org/4213 from Matteo Casalin
groupdialog.ui widget
   in https://gerrit.libreoffice.org/4208 from Manal Alhassoun
fdo#64977 Adding Tibetan Language Support
   in https://gerrit.libreoffice.org/4197 from Élie Roux

without going beyond 75 chars and with no wrap neither.

Since urls have fixed-length, I put them at start to ahve ~aligned things.

Attached is the patch, because dev-tools does not have the Change-Id hook  



Mat M
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Improve-mail-formatting-fix-query-parsing.patch
Type: application/octet-stream
Size: 2411 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20130611/57a87ca2/attachment.obj>

More information about the LibreOffice mailing list