[PATCH] cppcheck: fix duplicateExpression

Julien Nabet (via Code Review) gerrit at gerrit.libreoffice.org
Thu Jun 13 12:27:57 PDT 2013


I have submitted a patch for review:


To pull it, you can do:

    git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/78/4278/1

cppcheck: fix duplicateExpression

Change-Id: If3b7b1faab858afa82d4c665ee1a5036190e69aa
M binaryurp/source/lessoperators.cxx
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/binaryurp/source/lessoperators.cxx b/binaryurp/source/lessoperators.cxx
index 55f3a49..3a515f5 100644
--- a/binaryurp/source/lessoperators.cxx
+++ b/binaryurp/source/lessoperators.cxx
@@ -36,7 +36,7 @@
 	assert( rLeft.is() && rRight.is());
 	const typelib_TypeDescription& rA = *rLeft.get();
 	const typelib_TypeDescription& rB = *rRight.get();
-	if( rA.eTypeClass != rA.eTypeClass)
+        if( rA.eTypeClass != rB.eTypeClass)
 		return (rA.eTypeClass < rB.eTypeClass);
 	const sal_Int32 nCmp = rtl_ustr_compare_WithLength(
 			rA.pTypeName->buffer, rA.pTypeName->length,

To view, visit https://gerrit.libreoffice.org/4278
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: If3b7b1faab858afa82d4c665ee1a5036190e69aa
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Julien Nabet <serval2412 at yahoo.fr>

More information about the LibreOffice mailing list