[PATCH] Remove useless attributions in starmath

[Marcos Souza (via Code Review)]

Hi,

I have submitted a patch for review:

    https://gerrit.libreoffice.org/4282

To pull it, you can do:

    git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/82/4282/1

Remove useless attributions in starmath

These values are initialized as 0 in the constructor(see starmath/source/parse.cxx).

Change-Id: I68508f7f7132a2f43b99da3e7cdef9709fd62598
---
M starmath/source/mathmlimport.cxx
1 file changed, 0 insertions(+), 29 deletions(-)



diff --git a/starmath/source/mathmlimport.cxx b/starmath/source/mathmlimport.cxx
index b5f0529..4d1f95e 100644
--- a/starmath/source/mathmlimport.cxx
+++ b/starmath/source/mathmlimport.cxx
@@ -719,7 +719,6 @@
     {
         SmToken aToken;
         aToken.cMathChar = '\0';
-        aToken.nGroup = 0;
         aToken.nLevel = 5;
 
         if (nIsBold != -1)
@@ -960,7 +959,6 @@
 
     SmToken aToken;
     aToken.cMathChar = '\0';
-    aToken.nGroup = 0;
     aToken.nLevel = 5;
     aToken.eType = TPHANTOM;
 
@@ -1024,7 +1022,6 @@
 {
     SmToken aToken;
     aToken.cMathChar = '\0';
-    aToken.nGroup = 0;
     aToken.aText = ",";
     aToken.eType = TLEFT;
     aToken.nLevel = 5;
@@ -1110,7 +1107,6 @@
         : SmXMLImportContext(rImport,nPrefix,rLName)
     {
         aToken.cMathChar = '\0';
-        aToken.nGroup = 0;
         aToken.nLevel = 5;
         aToken.eType = TNUMBER;
     }
@@ -1190,7 +1186,6 @@
         : SmXMLImportContext(rImport,nPrefix,rLName)
     {
         aToken.cMathChar = '\0';
-        aToken.nGroup = 0;
         aToken.nLevel = 5;
         aToken.eType = TTEXT;
     }
@@ -1223,7 +1218,6 @@
         : SmXMLImportContext(rImport,nPrefix,rLName)
     {
         aToken.cMathChar = '\0';
-        aToken.nGroup = 0;
         aToken.nLevel = 5;
         aToken.eType = TTEXT;
     }
@@ -1267,7 +1261,6 @@
         : SmXMLImportContext(rImport,nPrefix,rLName),aStyleHelper(*this)
     {
         aToken.cMathChar = '\0';
-        aToken.nGroup = 0;
         aToken.nLevel = 5;
         aToken.eType = TIDENT;
     }
@@ -1332,7 +1325,6 @@
         const OUString& rLName)
         : SmXMLImportContext(rImport,nPrefix,rLName), bIsStretchy(sal_False)
     {
-        aToken.nGroup = 0;
         aToken.eType = TSPECIAL;
         aToken.nLevel = 5;
     }
@@ -1404,7 +1396,6 @@
 {
     SmToken aToken;
     aToken.cMathChar = '\0';
-    aToken.nGroup = 0;
     aToken.eType = TBLANK;
     aToken.nLevel = 5;
     SmBlankNode *pBlank = new SmBlankNode(aToken);
@@ -1441,8 +1432,6 @@
 
     SmToken aToken;
     aToken.cMathChar = '\0';
-    aToken.nGroup = 0;
-    aToken.nLevel = 0;
     aToken.eType = eType;
     SmSubSupNode *pNode = new SmSubSupNode(aToken);
     SmNodeStack &rNodeStack = GetSmImport().GetNodeStack();
@@ -1503,8 +1492,6 @@
 
     SmToken aToken;
     aToken.cMathChar = '\0';
-    aToken.nGroup = 0;
-    aToken.nLevel = 0;
     aToken.eType = eType;
     SmSubSupNode *pNode = new SmSubSupNode(aToken);
     SmNodeStack &rNodeStack = GetSmImport().GetNodeStack();
@@ -1557,8 +1544,6 @@
     SmNode *pTest = lcl_popOrZero(rNodeStack);
     SmToken aToken;
     aToken.cMathChar = '\0';
-    aToken.nGroup = 0;
-    aToken.nLevel = 0;
     aToken.eType = TUNDERLINE;
 
 
@@ -1632,8 +1617,6 @@
 
     SmToken aToken;
     aToken.cMathChar = '\0';
-    aToken.nGroup = 0;
-    aToken.nLevel = 0;
     aToken.eType = TACUTE;
 
     SmAttributNode *pNode = new SmAttributNode(aToken);
@@ -1701,7 +1684,6 @@
 {
     SmToken aToken;
     aToken.cMathChar = '\0';
-    aToken.nGroup = 0;
     aToken.aText = "";
     aToken.nLevel = 5;
     aToken.eType = TIDENT;
@@ -2184,8 +2166,6 @@
 
     SmToken aToken;
     aToken.cMathChar = '\0';
-    aToken.nGroup = 0;
-    aToken.nLevel = 0;
     aToken.eType = TOVER;
     SmStructureNode *pSNode = new SmBinVerNode(aToken);
     SmNode *pOper = new SmRectangleNode(aToken);
@@ -2205,8 +2185,6 @@
 
     SmToken aToken;
     aToken.cMathChar = MS_SQRT;  //Temporary: alert, based on StarSymbol font
-    aToken.nGroup = 0;
-    aToken.nLevel = 0;
     aToken.eType = TNROOT;
     SmStructureNode *pSNode = new SmRootNode(aToken);
     SmNode *pOper = new SmRootSymbolNode(aToken);
@@ -2229,8 +2207,6 @@
 
     SmToken aToken;
     aToken.cMathChar = MS_SQRT;  //Temporary: alert, based on StarSymbol font
-    aToken.nGroup = 0;
-    aToken.nLevel = 0;
     aToken.eType = TSQRT;
     SmStructureNode *pSNode = new SmRootNode(aToken);
     SmNode *pOper = new SmRootSymbolNode(aToken);
@@ -2266,7 +2242,6 @@
         {
             SmToken aToken;
             aToken.cMathChar = '\0';
-            aToken.nGroup = 0;
             aToken.nLevel = 5;
 
             int nLeft=0,nRight=0;
@@ -2321,7 +2296,6 @@
         aRelationArray.resize(1);
         SmToken aToken;
         aToken.cMathChar = '\0';
-        aToken.nGroup = 0;
         aToken.nLevel = 5;
         aToken.eType = TNEWLINE;
         aRelationArray[0] = new SmLineNode(aToken);
@@ -2452,8 +2426,6 @@
     {
         SmToken aToken;
         aToken.cMathChar = '\0';
-        aToken.nGroup = 0;
-        aToken.nLevel = 0;
         aToken.eType = bIsPrescript ? TLSUB : TRSUB;
 
         SmNodeStack aReverseStack;
@@ -2555,7 +2527,6 @@
     SmToken aToken;
     aToken.cMathChar = '\0';
     aToken.nGroup = TRGROUP;
-    aToken.nLevel = 0;
     aToken.eType = TMATRIX;
     SmMatrixNode *pSNode = new SmMatrixNode(aToken);
     pSNode->SetSubNodes(aExpressionArray);

-- 
To view, visit https://gerrit.libreoffice.org/4282
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I68508f7f7132a2f43b99da3e7cdef9709fd62598
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Marcos Souza <marcos.souza.org at gmail.com>