[PATCH] fdo#43460 chart2: use isEmpty()

Jelle van der Waa (via Code Review) gerrit at gerrit.libreoffice.org
Mon Jun 17 07:32:55 PDT 2013


Hi,

I have submitted a patch for review:

    https://gerrit.libreoffice.org/4315

To pull it, you can do:

    git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/15/4315/1

fdo#43460 chart2: use isEmpty()

Change-Id: Ia74923ed8f00adfa3f7758edb4e5755fedb0ec8a
---
M chart2/source/tools/ObjectIdentifier.cxx
1 file changed, 2 insertions(+), 2 deletions(-)



diff --git a/chart2/source/tools/ObjectIdentifier.cxx b/chart2/source/tools/ObjectIdentifier.cxx
index 9dc31b1..2358057 100644
--- a/chart2/source/tools/ObjectIdentifier.cxx
+++ b/chart2/source/tools/ObjectIdentifier.cxx
@@ -1005,7 +1005,7 @@
 {
     OUStringBuffer aRet(rParticle);
 
-    if( aRet.getLength() && !rChildParticle.isEmpty() )
+    if( !aRet.isEmpty() && !rChildParticle.isEmpty() )
         aRet.appendAscii(":");
     if( !rChildParticle.isEmpty() )
         aRet.append(rChildParticle);
@@ -1016,7 +1016,7 @@
 OUString ObjectIdentifier::createChildParticleWithIndex( ObjectType eObjectType, sal_Int32 nIndex )
 {
     OUStringBuffer aRet( getStringForType( eObjectType ) );
-    if( aRet.getLength() )
+    if( !aRet.isEmpty() )
     {
         aRet.appendAscii("=");
         aRet.append(OUString::valueOf(nIndex));

-- 
To view, visit https://gerrit.libreoffice.org/4315
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia74923ed8f00adfa3f7758edb4e5755fedb0ec8a
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Jelle van der Waa <jelle at vdwaa.nl>



More information about the LibreOffice mailing list