[PATCH] handle missing dep files in concat-deps

Björn Michaelsen (via_Code_Review) gerrit at gerrit.libreoffice.org
Tue Jun 18 01:07:10 PDT 2013


Hello LibreOffice gerrit bot, Norbert Thiebaud,

I'd like you to reexamine a change.  Please visit

    https://gerrit.libreoffice.org/4302

to look at the new patch set (#6).

Change subject: handle missing dep files in concat-deps
......................................................................

handle missing dep files in concat-deps

* this and Ib4762f5a260035f00b5e68cf45b687fdf02e9c02 reduces a default
  build on my machine from 2min25sec to 2min12sec
* without unitchecks, its down to 1min50sec now
* it reduces the build time on a i7-4770 Windows tinderbox from 99min to
  89min
* by now it also takes care of avoiding most string copying, although
  this can certainly be considered overeager given that the file
  creation on Windows took ~250ms per file before and still will take a
  lot longer than any string operation with this change

Change-Id: I515432bdefe2b055c78b6ba97868adbde65d9165
---
M solenv/bin/concat-deps.c
M solenv/gbuild/AllLangResTarget.mk
M solenv/gbuild/LinkTarget.mk
M solenv/gbuild/SdiTarget.mk
M solenv/gbuild/UnoApiTarget.mk
5 files changed, 132 insertions(+), 32 deletions(-)


  git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/02/4302/6
-- 
To view, visit https://gerrit.libreoffice.org/4302
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I515432bdefe2b055c78b6ba97868adbde65d9165
Gerrit-PatchSet: 6
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Björn Michaelsen <bjoern.michaelsen at canonical.com>
Gerrit-Reviewer: Björn Michaelsen <bjoern.michaelsen at canonical.com>
Gerrit-Reviewer: Jan Holesovsky <kendy at suse.cz>
Gerrit-Reviewer: LibreOffice gerrit bot <gerrit at libreoffice.org>
Gerrit-Reviewer: Norbert Thiebaud <nthiebaud at gmail.com>



More information about the LibreOffice mailing list