[PATCH] coverity#984440: Use after free

[Julien Nabet (via Code Review)]

Hi,

I have submitted a patch for review:

    https://gerrit.libreoffice.org/2496

To pull it, you can do:

    git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/96/2496/1

coverity#984440: Use after free

Change-Id: Ia6d62ce5421d51fe4fc0128f60e9b39ab736276b
---
M extensions/source/plugin/base/xplugin.cxx
1 file changed, 2 insertions(+), 2 deletions(-)



diff --git a/extensions/source/plugin/base/xplugin.cxx b/extensions/source/plugin/base/xplugin.cxx
index ea77d38..cc6f31b 100644
--- a/extensions/source/plugin/base/xplugin.cxx
+++ b/extensions/source/plugin/base/xplugin.cxx
@@ -444,8 +444,6 @@
 
     m_nProvidingState = PROVIDING_MODEL_UPDATE;
 
-    destroyInstance();
-
     m_aDescription = fitDescription( getCreationURL() );
     if( m_aDescription.Mimetype.isEmpty() )
     {
@@ -459,6 +457,8 @@
                       aURL,
                       0, 0, (sal_Bool)(aURL.compareToAscii( "file:", 5 ) == 0) );
     m_nProvidingState = PROVIDING_NONE;
+
+    destroyInstance();
 }
 
 OUString XPlugin_Impl::getCreationURL()

-- 
To view, visit https://gerrit.libreoffice.org/2496
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia6d62ce5421d51fe4fc0128f60e9b39ab736276b
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Julien Nabet <serval2412 at yahoo.fr>