[PATCH] No need for commented out code.

Chris Sherlock (via Code Review) gerrit at gerrit.libreoffice.org
Sun Mar 3 05:21:55 PST 2013


Hi,

I have submitted a patch for review:

    https://gerrit.libreoffice.org/2528

To pull it, you can do:

    git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/28/2528/1

No need for commented out code.

Change-Id: I8a8b7735574d712aea2a3f2b42941669b2db00b8
---
M dictionaries
M helpcontent2
M vcl/source/app/svapp.cxx
3 files changed, 1 insertion(+), 7 deletions(-)



diff --git a/dictionaries b/dictionaries
index 7e42390..8669b40 160000
--- a/dictionaries
+++ b/dictionaries
-Subproject commit 7e4239060266bf238b5e6692ed10d548c37572d5
+Subproject commit 8669b40a8835c007682507d1efd06f7f24452226
diff --git a/helpcontent2 b/helpcontent2
index b1cfd2b..7dded42 160000
--- a/helpcontent2
+++ b/helpcontent2
-Subproject commit b1cfd2b985bedae8929c2d798815b88e630e7a28
+Subproject commit 7dded42472968783f5c90a0aa9e497ee3dfb247f
diff --git a/vcl/source/app/svapp.cxx b/vcl/source/app/svapp.cxx
index 6db1ec6..2e160d2 100644
--- a/vcl/source/app/svapp.cxx
+++ b/vcl/source/app/svapp.cxx
@@ -1493,13 +1493,7 @@
                     return NULL;
                 }
 
-                // MAV: before the implementation has used only decorated windows,
-                //      but it is not true in case of ActiveX or plugin scenario,
-                //      so this check is commented out
-                // if( pWin->mpWindowImpl->mpFrameWindow->GetStyle() & (WB_MOVEABLE | WB_SIZEABLE) )
-                    return pWin->mpWindowImpl->mpFrameWindow->ImplGetWindow();
-                // else
-                //    return NULL;
+                return pWin->mpWindowImpl->mpFrameWindow->ImplGetWindow();
             }
         }
         // last active application frame

-- 
To view, visit https://gerrit.libreoffice.org/2528
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I8a8b7735574d712aea2a3f2b42941669b2db00b8
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Chris Sherlock <chris.sherlock79 at gmail.com>



More information about the LibreOffice mailing list