[PUSHED] Fixes fdo#60701 by escaping uri-encode path correctly
Stephan Bergmann
sbergman at redhat.com
Fri Mar 8 03:25:33 PST 2013
On 03/08/2013 05:32 AM, Fridrich Strba (via Code Review) wrote:
> Thank you for your patch! It has been merged to LibreOffice.
>
> If you are interested in details, please visit
>
> https://gerrit.libreoffice.org/2588
>
> Approvals:
> Fridrich Strba: Verified; Looks good to me, approved
But how does
> diff --git a/shell/source/unix/misc/senddoc.sh b/shell/source/unix/misc/senddoc.sh
> index 0ff1594..a2c53fd 100644
> --- a/shell/source/unix/misc/senddoc.sh
> +++ b/shell/source/unix/misc/senddoc.sh
> @@ -18,6 +18,7 @@
> #
>
> URI_ENCODE="`dirname $0`/uri-encode"
> +URI_ENCODE=$(printf "%b" "$(URI_ENCODE)")
> FOPTS=""
> sd_platform=`uname -s`
>
fix <https://bugs.freedesktop.org/show_bug.cgi?id=60701> "Send Document
as email fails, when application is installed to a directory with a
space" in any way?
The solution should be to properly quote the argument to dirname,
> URI_ENCODE=`dirname "$0"`/uri-encode
What the printf '%b' does is break things if the path to LO contains
character sequences like "\n".
Stephan
More information about the LibreOffice
mailing list