[PATCH] evoab2: Move get_e_source_registry() to EApi.cxx

Mathias Hasselmann (via Code Review) gerrit at gerrit.libreoffice.org
Fri Mar 8 05:03:58 PST 2013


Hi,

I have submitted a patch for review:

    https://gerrit.libreoffice.org/2597

To pull it, you can do:

    git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/97/2597/1

evoab2: Move get_e_source_registry() to EApi.cxx

get_e_source_registry() was declared in EApi.hxx, but defined in
NDatabaseMetaData.cxx. This doesn't seem right, the header file
and the purpose of the function indicate that it belongs into
EApi.cxx.

Change-Id: Iea3f11a901398aa3f467b96fbe8778c403887bcb
---
M connectivity/source/drivers/evoab2/EApi.cxx
M connectivity/source/drivers/evoab2/NDatabaseMetaData.cxx
2 files changed, 8 insertions(+), 8 deletions(-)



diff --git a/connectivity/source/drivers/evoab2/EApi.cxx b/connectivity/source/drivers/evoab2/EApi.cxx
index 8e0d0db..987510c 100644
--- a/connectivity/source/drivers/evoab2/EApi.cxx
+++ b/connectivity/source/drivers/evoab2/EApi.cxx
@@ -143,4 +143,12 @@
     return false;
 }
 
+ESourceRegistry *get_e_source_registry()
+{
+    static ESourceRegistry *theInstance;
+    if (!theInstance)
+        theInstance = e_source_registry_new_sync(NULL, NULL);
+    return theInstance;
+}
+
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/connectivity/source/drivers/evoab2/NDatabaseMetaData.cxx b/connectivity/source/drivers/evoab2/NDatabaseMetaData.cxx
index bfe9f01..a214bd1 100644
--- a/connectivity/source/drivers/evoab2/NDatabaseMetaData.cxx
+++ b/connectivity/source/drivers/evoab2/NDatabaseMetaData.cxx
@@ -1086,14 +1086,6 @@
     return xResultSet;
 }
 
-ESourceRegistry *get_e_source_registry()
-{
-    static ESourceRegistry *theInstance;
-    if (!theInstance)
-        theInstance = e_source_registry_new_sync(NULL, NULL);
-    return theInstance;
-}
-
 // -------------------------------------------------------------------------
 bool isSourceBackend(ESource *pSource, const char *backendname)
 {

-- 
To view, visit https://gerrit.libreoffice.org/2597
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iea3f11a901398aa3f467b96fbe8778c403887bcb
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Mathias Hasselmann <mathias at openismus.com>



More information about the LibreOffice mailing list