[PATCH] Documentation to avoid a real use-after-free bug

[Marc-André Laverdière (via_Code_Review)]

Hi,

I have submitted a patch for review:

    https://gerrit.libreoffice.org/2608

To pull it, you can do:

    git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/08/2608/1

Documentation to avoid a real use-after-free bug

Change-Id: Ie8a4432b0a70703fbfe92480ad0608b659a887d0
---
M svtools/source/contnr/treelist.cxx
1 file changed, 3 insertions(+), 0 deletions(-)



diff --git a/svtools/source/contnr/treelist.cxx b/svtools/source/contnr/treelist.cxx
index 307d861..55beae9 100644
--- a/svtools/source/contnr/treelist.cxx
+++ b/svtools/source/contnr/treelist.cxx
@@ -1268,6 +1268,9 @@
 
 void SvListView::ModelHasRemoved( SvTreeListEntry* )
 {
+    //WARNING WARNING WARNING
+    //The supplied pointer should have been deleted
+    //before this call. Be careful not to use it!!!
     DBG_CHKTHIS(SvListView,0);
 }
 

-- 
To view, visit https://gerrit.libreoffice.org/2608
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie8a4432b0a70703fbfe92480ad0608b659a887d0
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Marc-André Laverdière <marc-andre at atc.tcs.com>