[PATCH libreoffice-4-0] fix fdo#59892 completely and fdo#33302 partially.

Lior Kaplan (via Code Review) gerrit at gerrit.libreoffice.org
Thu Mar 14 08:23:23 PDT 2013


Hi,

I have submitted a patch for review:

    https://gerrit.libreoffice.org/2728

To pull it, you can do:

    git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/28/2728/1

fix fdo#59892 completely and fdo#33302 partially.

fix fdo#33302 for rtl scripts in cal,impress and draw.

Reviewed-on: https://gerrit.libreoffice.org/1961
Reviewed-by: Ahmad Harthi <aalharthi at kacst.edu.sa>
Tested-by: Ahmad Harthi <aalharthi at kacst.edu.sa>
(cherry picked from commit 73de30ca9ca0d3d4edd00e0e8f22451238699989)

fix logic to get L/R direction

Reviewed-on: https://gerrit.libreoffice.org/1972
Reviewed-by: Norbert Thiebaud <nthiebaud at gmail.com>
Tested-by: Norbert Thiebaud <nthiebaud at gmail.com>
(cherry picked from commit fb697ed0ab6e0182b45c78412563c51d6f22f9d5)

Change-Id: I21449d8ee236d798481fc61fbb1b4d12623cac90
Signed-off-by: Lior Kaplan <kaplanlior at gmail.com>
---
M editeng/source/editeng/impedit3.cxx
1 file changed, 4 insertions(+), 3 deletions(-)



diff --git a/editeng/source/editeng/impedit3.cxx b/editeng/source/editeng/impedit3.cxx
index b45c826..bada916 100644
--- a/editeng/source/editeng/impedit3.cxx
+++ b/editeng/source/editeng/impedit3.cxx
@@ -4300,7 +4300,7 @@
 void ImpEditEngine::ImplInitLayoutMode( OutputDevice* pOutDev, sal_uInt16 nPara, sal_uInt16 nIndex )
 {
     sal_Bool bCTL = sal_False;
-    sal_uInt8 bR2L = sal_False;
+    sal_Bool bR2L = sal_False;
     if ( nIndex == 0xFFFF )
     {
         bCTL = HasScriptType( nPara, i18n::ScriptType::COMPLEX );
@@ -4311,8 +4311,9 @@
         ContentNode* pNode = GetEditDoc().GetObject( nPara );
         short nScriptType = GetScriptType( EditPaM( pNode, nIndex+1 ) );
         bCTL = nScriptType == i18n::ScriptType::COMPLEX;
-        bR2L = GetRightToLeft( nPara, nIndex + 1);  // this change was discussed in issue 37190
-                                                    // it also works for issue 55927
+        // this change was discussed in issue 37190
+        bR2L = GetRightToLeft( nPara, nIndex + 1) % 2 ? sal_True : sal_False;
+        // it also works for issue 55927
     }
 
     sal_uLong nLayoutMode = pOutDev->GetLayoutMode();

-- 
To view, visit https://gerrit.libreoffice.org/2728
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I21449d8ee236d798481fc61fbb1b4d12623cac90
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: libreoffice-4-0
Gerrit-Owner: Lior Kaplan <kaplanlior at gmail.com>
Gerrit-Reviewer: navin patidar <patidar at kacst.edu.sa>



More information about the LibreOffice mailing list