[PATCH] coverity#708921: Use after free

Julien Nabet (via Code Review) gerrit at gerrit.libreoffice.org
Thu Mar 14 23:40:31 PDT 2013


Hi,

I have submitted a patch for review:

    https://gerrit.libreoffice.org/2738

To pull it, you can do:

    git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/38/2738/1

coverity#708921: Use after free

Change-Id: I446fa717dfd11fc5d6045cb1e8dc3eaf8861262e
---
M svx/source/gallery2/galtheme.cxx
1 file changed, 1 insertion(+), 1 deletion(-)



diff --git a/svx/source/gallery2/galtheme.cxx b/svx/source/gallery2/galtheme.cxx
index 3db3a8a..0afd03e 100644
--- a/svx/source/gallery2/galtheme.cxx
+++ b/svx/source/gallery2/galtheme.cxx
@@ -87,8 +87,8 @@
     {
         GalleryObject* pEntry = aObjectList[ i ];
         Broadcast( GalleryHint( GALLERY_HINT_CLOSE_OBJECT, GetName(), reinterpret_cast< sal_uIntPtr >( pEntry ) ) );
-        delete pEntry;
         Broadcast( GalleryHint( GALLERY_HINT_OBJECT_REMOVED, GetName(), reinterpret_cast< sal_uIntPtr >( pEntry ) ) );
+        delete pEntry;
     }
     aObjectList.clear();
 

-- 
To view, visit https://gerrit.libreoffice.org/2738
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I446fa717dfd11fc5d6045cb1e8dc3eaf8861262e
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Julien Nabet <serval2412 at yahoo.fr>



More information about the LibreOffice mailing list