build failures with mdds 0.6 (Tinderbox)

[lionel at mamane.lu]

On Fri, Mar 15, 2013 at 06:49:41AM +0000, Tomas Chvatal wrote:

> One of you broke the build of LibreOffice with your commit :-(
> Please commit and push a fix ASAP!

>  Configured with: --prefix=/usr
> --with-system-libs
> In file included from /home/scarabeus/libreoffice-tinderbox/repo/sc/qa/unit/ucalc.cxx:68:0:
> /home/scarabeus/libreoffice-tinderbox/repo/sc/inc/columniterator.hxx:26:5: error: 'iterator' in 'ScColumnTextWidthIterator::TextWidthType {aka class mdds::multi_type_vector<mdds::mtv::element_block_func>}' does not name a type
> /home/scarabeus/libreoffice-tinderbox/repo/sc/inc/columniterator.hxx:27:5: error: 'iterator' in 'ScColumnTextWidthIterator::TextWidthType {aka class mdds::multi_type_vector<mdds::mtv::element_block_func>}' does not name a type
> /home/scarabeus/libreoffice-tinderbox/repo/sc/inc/columniterator.hxx:28:5: error: 'iterator' in 'mdds::mtv::ushort_element_block {aka struct mdds::mtv::default_element_block<3, short unsigned int>}' does not name a type
> /home/scarabeus/libreoffice-tinderbox/repo/sc/inc/columniterator.hxx:29:5: error: 'iterator' in 'mdds::mtv::ushort_element_block {aka struct mdds::mtv::default_element_block<3, short unsigned int>}' does not name a type


I had the same kind of error messages on my machine, also with system
libraries. They seem to have gone away by upgrading to mdds 0.7.1. I
see our internal mdds is now 0.7.1 (upgraded by Kohei); if we require
this version for some reason or another, then probably we should check
for it in configure.ac?

Note that although our configure.ac has:

    AC_CHECK_HEADER(mdds/multi_type_matrix.hpp, [],
        [AC_MSG_ERROR(mdds/multi_type_matrix.hpp not found. install
	mdds >= 0.7.0)], [])

This test did not trigger an error on my system with mdds 0.6.1, so
the error message seems to indicate that the test does not do what its
author intended. Ah yes, look:

commit 4613d78e6aceabafbc4dd066c7c0a55d728b6763
Author: Kohei Yoshida <kohei.yoshida at gmail.com>
Date:   Tue Mar 12 15:45:19 2013 -0400

    Updated mdds to 0.7.0.

    Change-Id: I5e4a4b80a0f83aefcd85cf5e76ccd52906d39f83

diff --git a/configure.ac b/configure.ac
index a017909..b202172 100644
--- a/configure.ac
+++ b/configure.ac
@@ -7920,7 +7920,7 @@ if test "$with_system_mdds" = "yes"; then
     AC_CHECK_HEADER(mdds/flat_segment_tree.hpp, [],
         [AC_MSG_ERROR(mdds/flat_segment_tree.hpp not found. install
	 mdds)], [])
     AC_CHECK_HEADER(mdds/multi_type_matrix.hpp, [],
-        [AC_MSG_ERROR(mdds/multi_type_matrix.hpp not found. install mdds >= 0.6.0)], [])
+        [AC_MSG_ERROR(mdds/multi_type_matrix.hpp not found. install mdds >= 0.7.0)], [])
     CPPFLAGS="$save_CPPFLAGS"
     AC_LANG_POP([C++])
 else



-- 
Lionel