#ifdef vs #if for feature checks

Noel Grandin noelgrandin at gmail.com
Sat Mar 16 05:23:49 PDT 2013


On Fri, Mar 15, 2013 at 5:58 PM, Lubos Lunak <l.lunak at suse.cz> wrote:

>
>  The problem with this change is that there still may be some cases where
> #ifdef is used, either because some system #defines work that way (so those
> would be valid but different), or people would still use #ifdef out of
> habbit
>

I like the general idea.
Perhaps we could build a small whitelist of the values for which #ifdef is
allowed?
There can't be very many of them.
Then the mechanical checker can become part of the toolkit we use to keep
the codebase sane.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20130316/78d49b2e/attachment.html>


More information about the LibreOffice mailing list