[PATCH] coverity#705115 Using invalid iterator

Julien Nabet (via Code Review) gerrit at gerrit.libreoffice.org
Sun Mar 17 03:00:41 PDT 2013


Hi,

I have submitted a patch for review:

    https://gerrit.libreoffice.org/2785

To pull it, you can do:

    git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/85/2785/1

coverity#705115 Using invalid iterator

Change-Id: Ia8b5a0654ded07d939e8be93a2dea2a6f84165b3
---
M sw/source/ui/dbui/mmaddressblockpage.cxx
1 file changed, 1 insertion(+), 2 deletions(-)



diff --git a/sw/source/ui/dbui/mmaddressblockpage.cxx b/sw/source/ui/dbui/mmaddressblockpage.cxx
index e07eb09..bfd6e80 100644
--- a/sw/source/ui/dbui/mmaddressblockpage.cxx
+++ b/sw/source/ui/dbui/mmaddressblockpage.cxx
@@ -911,8 +911,7 @@
         {
             if(aSearch == aControls.begin())
                 aSearch = aControls.end();
-            else
-                --aSearch;
+            --aSearch;
             if( (*aSearch)->IsEnabled() )
             {
                 (*aSearch)->GrabFocus();

-- 
To view, visit https://gerrit.libreoffice.org/2785
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia8b5a0654ded07d939e8be93a2dea2a6f84165b3
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Julien Nabet <serval2412 at yahoo.fr>



More information about the LibreOffice mailing list