#ifdef vs #if for feature checks
Michael Meeks
michael.meeks at suse.com
Mon Mar 18 02:42:57 PDT 2013
On Sat, 2013-03-16 at 21:18 -0500, Norbert Thiebaud wrote:
> On Fri, Mar 15, 2013 at 10:58 AM, Lubos Lunak <l.lunak at suse.cz> wrote:
> > I'd like to propose that we convert our
> >
> > #ifdef HAVE_FOO
> > to
> > #if HAVE_FOO
>
> +1
Sounds great to me too; though of course I'd prefer to keep the diff
smaller and not replace all the header guards:
#ifndef INCLUDED_OOXML_FAST_CONTEXT_HANDLER_HXX
#define INCLUDED_OOXML_FAST_CONTEXT_HANDLER_HXX
Which I suspect don't suffer this problem so badly. Given the
reasonably small number of #ifdef conditionals, I guess it'd be fine to
replace them before we've got 4.0.2 out in the wild too :-)
Thanks !
Michael.
--
michael.meeks at suse.com <><, Pseudo Engineer, itinerant idiot
More information about the LibreOffice
mailing list