#ifdef vs #if for feature checks

Norbert Thiebaud nthiebaud at gmail.com
Mon Mar 18 07:03:43 PDT 2013


On Mon, Mar 18, 2013 at 4:42 AM, Michael Meeks <michael.meeks at suse.com> wrote:
>
> On Sat, 2013-03-16 at 21:18 -0500, Norbert Thiebaud wrote:
>> On Fri, Mar 15, 2013 at 10:58 AM, Lubos Lunak <l.lunak at suse.cz> wrote:
>> >  I'd like to propose that we convert our
>> >
>> > #ifdef HAVE_FOO
>> > to
>> > #if HAVE_FOO
>>
>>  +1
>
>         Sounds great to me too; though of course I'd prefer to keep the diff
> smaller and not replace all the header guards:
>
> #ifndef INCLUDED_OOXML_FAST_CONTEXT_HANDLER_HXX
> #define INCLUDED_OOXML_FAST_CONTEXT_HANDLER_HXX

oh!, ny +1 was for HAVE_* and the like, not header guard...
iow for pre-compiler variable used to 'configure' things... not
mechanical ones like header guard.

Norbert


More information about the LibreOffice mailing list