#ifdef vs #if for feature checks

Norbert Thiebaud nthiebaud at gmail.com
Mon Mar 18 16:02:50 PDT 2013


On Mon, Mar 18, 2013 at 11:17 AM, Lubos Lunak <l.lunak at suse.cz> wrote:
> On Monday 18 of March 2013, Tor Lillqvist wrote:
>> > Sounds great to me too; though of course I'd prefer to keep the diff
>> > smaller and not replace all the header guards:
>> >
>> > #ifndef INCLUDED_OOXML_FAST_CONTEXT_HANDLER_HXX
>> > #define INCLUDED_OOXML_FAST_CONTEXT_HANDLER_HXX
...
>> Oh the other hand, it would be nice if the header guards were
>> consistently named... and didn't start with an underscore (such
>> identifiers are supposed to be reserved for the language and/or OS
>> implementation, unless I am mistaken). Somebody just needs to come up
>> with a consistent naming style and do it (with some nice script). (The
>> style of above example would be fine with me.)
>
>  Yes, a script should be enough for this. And yes, "somebody" just needs to do
> it :).

otoh, #pragma once is supported by all the compiler we use isn't it ?
so if we are going to change it, why not use that instead.

Norbert


More information about the LibreOffice mailing list