[PATCH] fix fdo#62050 : Initially disable RTL for comment window.

navin patidar (via Code Review) gerrit at gerrit.libreoffice.org
Mon Mar 18 23:02:45 PDT 2013


Hi,

I have submitted a patch for review:

    https://gerrit.libreoffice.org/2831

To pull it, you can do:

    git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/31/2831/1

fix fdo#62050 : Initially disable RTL for comment window.

In RTL UI, comment window is RTL and editbox’s (editeng) default writing
direction is LTR.
and i suspect, the bug is result of this RTL & LTR mix-up.

Change-Id: If3af4ae428b67151d66661907b9e60a97049e0e6
---
M sw/source/ui/docvw/SidebarWin.cxx
1 file changed, 1 insertion(+), 4 deletions(-)



diff --git a/sw/source/ui/docvw/SidebarWin.cxx b/sw/source/ui/docvw/SidebarWin.cxx
index 67fb1f6..b32fbe4 100644
--- a/sw/source/ui/docvw/SidebarWin.cxx
+++ b/sw/source/ui/docvw/SidebarWin.cxx
@@ -320,16 +320,13 @@
     mpOutliner->SetUpdateMode( sal_True );
     Rescale();
 
+    mpSidebarTxtControl->EnableRTL( sal_False );
     mpOutlinerView = new OutlinerView ( mpOutliner, mpSidebarTxtControl );
     mpOutlinerView->SetBackgroundColor(COL_TRANSPARENT);
     mpOutliner->InsertView(mpOutlinerView );
     mpOutlinerView->SetOutputArea( PixelToLogic( Rectangle(0,0,1,1) ) );
 
     mpOutlinerView->SetAttribs(DefaultItem());
-
-    // TODO: ??
-    EEHorizontalTextDirection aDefHoriTextDir = Application::GetSettings().GetLayoutRTL() ? EE_HTEXTDIR_R2L : EE_HTEXTDIR_L2R;
-    mpOutliner->SetDefaultHorizontalTextDirection( aDefHoriTextDir );
 
     //create Scrollbars
     mpVScrollbar = new ScrollBar(this, WB_3DLOOK |WB_VSCROLL|WB_DRAG);

-- 
To view, visit https://gerrit.libreoffice.org/2831
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: If3af4ae428b67151d66661907b9e60a97049e0e6
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: navin patidar <patidar at kacst.edu.sa>



More information about the LibreOffice mailing list