#ifdef vs #if for feature checks

Norbert Thiebaud nthiebaud at gmail.com
Tue Mar 19 18:22:52 PDT 2013


On Tue, Mar 19, 2013 at 12:16 PM, Jan Holesovsky <kendy at suse.cz> wrote:
>
> That's a good point; so I think the person doing the script should check
> the build time of the entire LO with #pragma before pushing, but
> otherwise I wouldn't block the change just based on the benchmark - the
> benchmark might, or might not be relevant to our scenario :-)

actually the numbers seems to indicate a faster windows for a slower
gcc (and clang unchanged)
considering that windows perf is a bottleneck whereas linux is not..
it seems like a good trade-off
So no the performance impact should not outweigh the benefit here..

Norbert


More information about the LibreOffice mailing list