[PATCH] coverity#704774 Explicit null dereferenced

Julien Nabet (via Code Review) gerrit at gerrit.libreoffice.org
Wed Mar 20 05:59:54 PDT 2013


Hi,

I have submitted a patch for review:

    https://gerrit.libreoffice.org/2870

To pull it, you can do:

    git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/70/2870/1

coverity#704774 Explicit null dereferenced

Change-Id: Ief63d63233d11015f64f5e6a19544889f0389ca3
---
M sd/source/ui/view/OutlinerIterator.cxx
1 file changed, 4 insertions(+), 0 deletions(-)



diff --git a/sd/source/ui/view/OutlinerIterator.cxx b/sd/source/ui/view/OutlinerIterator.cxx
index 450a747..b1b39aa 100644
--- a/sd/source/ui/view/OutlinerIterator.cxx
+++ b/sd/source/ui/view/OutlinerIterator.cxx
@@ -757,6 +757,10 @@
     // Move iterator to the current object.
     SdrObjectWeakRef xObject = maPosition.mxObject;
     maPosition.mxObject.reset(NULL);
+
+    if (!mpObjectIterator)
+        return;
+
     while (mpObjectIterator->IsMore() && maPosition.mxObject != xObject)
         maPosition.mxObject.reset(mpObjectIterator->Next());
 }

-- 
To view, visit https://gerrit.libreoffice.org/2870
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ief63d63233d11015f64f5e6a19544889f0389ca3
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Julien Nabet <serval2412 at yahoo.fr>



More information about the LibreOffice mailing list