[PATCH] Move setupwizard modify handler code.

Chris Sherlock (via Code Review) gerrit at gerrit.libreoffice.org
Thu Mar 21 05:57:06 PDT 2013


Hi,

I have submitted a patch for review:

    https://gerrit.libreoffice.org/2890

To pull it, you can do:

    git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/90/2890/1

Move setupwizard modify handler code.

Move setupwizard code into the conditional below it. You can only work
on pPage if it isn't a null pointer anyway, to my mind this looks a
lot cleaner.

Change-Id: If8d910c15c5a1c1da5eb204b5922d074c454978b
---
M dbaccess/source/ui/dlg/dbwizsetup.cxx
1 file changed, 5 insertions(+), 5 deletions(-)



diff --git a/dbaccess/source/ui/dlg/dbwizsetup.cxx b/dbaccess/source/ui/dlg/dbwizsetup.cxx
index 338e7c0..cb53dfd 100644
--- a/dbaccess/source/ui/dlg/dbwizsetup.cxx
+++ b/dbaccess/source/ui/dlg/dbwizsetup.cxx
@@ -587,13 +587,13 @@
             break;
     }
 
-    if (pPage && (_nState != PAGE_DBSETUPWIZARD_INTRO) && (_nState != PAGE_DBSETUPWIZARD_AUTHENTIFICATION))
-    {
-        pPage->SetModifiedHandler(LINK( this, ODbTypeWizDialogSetup, ImplModifiedHdl ) );
-    }
-
     if ( pPage )
     {
+        if ((_nState != PAGE_DBSETUPWIZARD_INTRO) && (_nState != PAGE_DBSETUPWIZARD_AUTHENTIFICATION))
+        {
+            pPage->SetModifiedHandler(LINK( this, ODbTypeWizDialogSetup, ImplModifiedHdl ) );
+        }
+
         pPage->SetServiceFactory( m_pImpl->getORB() );
         pPage->SetAdminDialog(this, this);
 

-- 
To view, visit https://gerrit.libreoffice.org/2890
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: If8d910c15c5a1c1da5eb204b5922d074c454978b
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Chris Sherlock <chris.sherlock79 at gmail.com>



More information about the LibreOffice mailing list