[PATCH] fix fdo#62050: for impress

navin patidar (via Code Review) gerrit at gerrit.libreoffice.org
Fri Mar 22 23:54:23 PDT 2013


Hi,

I have submitted a patch for review:

    https://gerrit.libreoffice.org/2922

To pull it, you can do:

    git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/22/2922/1

fix fdo#62050: for impress

Impress is also affected by fdo#62050.
In RTL UI, comment window is RTL and editbox’s (editeng) default
writing direction is LTR.
I suspect, bug is result of this RTL & LTR mix-up.

Change-Id: I188ce05350f721081378509915158d4ec4e5f8cf
---
M sd/source/ui/annotations/annotationwindow.cxx
1 file changed, 1 insertion(+), 4 deletions(-)



diff --git a/sd/source/ui/annotations/annotationwindow.cxx b/sd/source/ui/annotations/annotationwindow.cxx
index 2a859f0..d03548a 100644
--- a/sd/source/ui/annotations/annotationwindow.cxx
+++ b/sd/source/ui/annotations/annotationwindow.cxx
@@ -327,14 +327,11 @@
         mpOutliner->SetRefDevice( pDev );
     }
 
+    mpTextWindow->EnableRTL( sal_False );
     mpOutlinerView = new OutlinerView ( mpOutliner, mpTextWindow );
     mpOutliner->InsertView(mpOutlinerView );
     mpTextWindow->SetOutlinerView(mpOutlinerView);
     mpOutlinerView->SetOutputArea( PixelToLogic( Rectangle(0,0,1,1) ) );
-
-    // TODO: ??
-    EEHorizontalTextDirection aDefHoriTextDir = Application::GetSettings().GetLayoutRTL() ? EE_HTEXTDIR_R2L : EE_HTEXTDIR_L2R;
-    mpOutliner->SetDefaultHorizontalTextDirection( aDefHoriTextDir );
 
     //create Scrollbars
     mpVScrollbar = new ScrollBar(this, WB_3DLOOK |WB_VSCROLL|WB_DRAG);

-- 
To view, visit https://gerrit.libreoffice.org/2922
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I188ce05350f721081378509915158d4ec4e5f8cf
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: navin patidar <patidar at kacst.edu.sa>



More information about the LibreOffice mailing list