[PATCH] Related coverity#704213/704214/704215 Logically dead code

[Julien Nabet (via Code Review)]

Hi,

I have submitted a patch for review:

    https://gerrit.libreoffice.org/2930

To pull it, you can do:

    git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/30/2930/1

Related coverity#704213/704214/704215 Logically dead code

Change-Id: I80c119b2287ff0c4f2e467943be6a7682914934a
---
M chart2/source/controller/main/DrawCommandDispatch.cxx
1 file changed, 3 insertions(+), 3 deletions(-)



diff --git a/chart2/source/controller/main/DrawCommandDispatch.cxx b/chart2/source/controller/main/DrawCommandDispatch.cxx
index 8dbd956..57b629e 100644
--- a/chart2/source/controller/main/DrawCommandDispatch.cxx
+++ b/chart2/source/controller/main/DrawCommandDispatch.cxx
@@ -403,7 +403,7 @@
                                 m_pChartController->m_aSelection.setSelection( xShape );
                                 m_pChartController->m_aSelection.applySelection( pDrawViewWrapper );
                             }
-                            if ( nFeatureId == SID_DRAW_TEXT )
+                            if ( nFeatureId == COMMAND_ID_DRAW_TEXT )
                             {
                                 m_pChartController->StartTextEdit();
                             }
@@ -517,7 +517,7 @@
                                 if ( pTextObj )
                                 {
                                     pTextObj->SetLogicRect( aRect );
-                                    sal_Bool bVertical = ( nID == SID_DRAW_TEXT_VERTICAL );
+                                    sal_Bool bVertical = ( nID == COMMAND_ID_DRAW_TEXT_VERTICAL );
                                     pTextObj->SetVerticalWriting( bVertical );
                                     if ( bVertical )
                                     {
@@ -537,7 +537,7 @@
                         {
                             if ( pObj->ISA( SdrCaptionObj ) )
                             {
-                                sal_Bool bIsVertical( SID_DRAW_CAPTION_VERTICAL == nID );
+                                sal_Bool bIsVertical( COMMAND_ID_DRAW_CAPTION_VERTICAL == nID );
                                 SdrTextObj* pTextObj = dynamic_cast< SdrTextObj* >( pObj );
                                 if ( pTextObj )
                                 {

-- 
To view, visit https://gerrit.libreoffice.org/2930
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I80c119b2287ff0c4f2e467943be6a7682914934a
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Julien Nabet <serval2412 at yahoo.fr>