[PATCH] coverity#704243 Logically dead code

Julien Nabet (via Code Review) gerrit at gerrit.libreoffice.org
Sat Mar 23 12:16:29 PDT 2013


Hi,

I have submitted a patch for review:

    https://gerrit.libreoffice.org/2942

To pull it, you can do:

    git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/42/2942/1

coverity#704243 Logically dead code

Change-Id: Ie1140a90a6c9723582fa5e18ca0cf1dc1f918742
---
M package/source/zipapi/blowfishcontext.cxx
1 file changed, 2 insertions(+), 2 deletions(-)



diff --git a/package/source/zipapi/blowfishcontext.cxx b/package/source/zipapi/blowfishcontext.cxx
index 6f43d54..0d6bd2c 100644
--- a/package/source/zipapi/blowfishcontext.cxx
+++ b/package/source/zipapi/blowfishcontext.cxx
@@ -72,7 +72,7 @@
 
     if ( m_bEncrypt )
     {
-        rtl_cipher_encode( m_pCipher,
+        nError = rtl_cipher_encode( m_pCipher,
                           aData.getConstArray(),
                           aData.getLength(),
                           reinterpret_cast< sal_uInt8* >( aResult.getArray() ),
@@ -80,7 +80,7 @@
     }
     else
     {
-        rtl_cipher_decode( m_pCipher,
+        nError = rtl_cipher_decode( m_pCipher,
                           aData.getConstArray(),
                           aData.getLength(),
                           reinterpret_cast< sal_uInt8* >( aResult.getArray() ),

-- 
To view, visit https://gerrit.libreoffice.org/2942
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie1140a90a6c9723582fa5e18ca0cf1dc1f918742
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Julien Nabet <serval2412 at yahoo.fr>



More information about the LibreOffice mailing list