[PATCH] coverity#704247 Logically dead code

Julien Nabet (via Code Review) gerrit at gerrit.libreoffice.org
Sat Mar 23 13:37:28 PDT 2013


Hi,

I have submitted a patch for review:

    https://gerrit.libreoffice.org/2952

To pull it, you can do:

    git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/52/2952/1

coverity#704247 Logically dead code

Change-Id: Iaefddeb816d36d4a07234d903fafab3d6b83e1d2
---
M sal/rtl/strtmpl.cxx
1 file changed, 1 insertion(+), 4 deletions(-)



diff --git a/sal/rtl/strtmpl.cxx b/sal/rtl/strtmpl.cxx
index 5f59795..69bd5ee 100644
--- a/sal/rtl/strtmpl.cxx
+++ b/sal/rtl/strtmpl.cxx
@@ -303,10 +303,7 @@
         h = (h*39) + IMPL_RTL_USTRCODE( *pStr );
         pStr++;
 
-        if ( nLen < 32 )
-            nSkip = nLen / 4;
-        else
-            nSkip = nLen / 8;
+        nSkip = nLen / 8;
         nLen -= 8;
         while ( nLen > 0 )
         {

-- 
To view, visit https://gerrit.libreoffice.org/2952
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iaefddeb816d36d4a07234d903fafab3d6b83e1d2
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Julien Nabet <serval2412 at yahoo.fr>



More information about the LibreOffice mailing list